[asterisk-dev] [Code Review] Top down test "one step parking" GSOC 2010

[mnick at digium.com]

> On 2010-07-28 13:34:56, pabelanger wrote:
> > /asterisk/trunk/tests/one-step-parking/configs/features.conf, line 8
> > <https://reviewboard.asterisk.org/r/811/diff/1/?file=11942#file11942line8>
> >
> >     This looks to be the only change with-in features.conf. I recommend we actually remove this file and use the default settings that ship will asterisk.  This will allow use to confirm out-of-the box functionality.

actually, #72 isn't default, there is no default value for parkcall. 
I changed from * to #72


> On 2010-07-28 13:34:56, pabelanger wrote:
> > /asterisk/trunk/tests/one-step-parking/configs2/extensions.conf, line 14
> > <https://reviewboard.asterisk.org/r/811/diff/1/?file=11945#file11945line14>
> >
> >     Same as above comment, lets use the default settings to park (#72).

see my comment, #72 isn't default, but I changed it to #72


> On 2010-07-28 13:34:56, pabelanger wrote:
> > /asterisk/trunk/tests/one-step-parking/configs2/logger.conf, line 2
> > <https://reviewboard.asterisk.org/r/811/diff/1/?file=11947#file11947line2>
> >
> >     Same comment as before

added your suggestions, thanks pabelanger !


- mnick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/811/#review2498
-----------------------------------------------------------


On 2010-07-29 17:49:16, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-07-29 17:49:16)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "one step parking" top down test for asterisk:
> 
> userA calls userB
> userB parks userA by '*' - one step parking
> userB retrieves userA by calling 701
> - Test successful - 
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs/features.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs/iax.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs/logger.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs2/extensions.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs2/iax.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/configs2/logger.conf 601 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test 601 
> 
> Diff: https://reviewboard.asterisk.org/r/811/diff
> 
> 
> Testing
> -------
> 
> tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>