[asterisk-dev] [Code Review] Top down test "one step parking" GSOC 2010

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/811/#review2498
-----------------------------------------------------------


Simple review, good work.


/asterisk/trunk/tests/one-step-parking/configs/features.conf
<https://reviewboard.asterisk.org/r/811/#comment5505>

    This looks to be the only change with-in features.conf. I recommend we actually remove this file and use the default settings that ship will asterisk.  This will allow use to confirm out-of-the box functionality. 



/asterisk/trunk/tests/one-step-parking/configs/logger.conf
<https://reviewboard.asterisk.org/r/811/#comment5506>

    Strip this down.  No need to ship a complete sample.



/asterisk/trunk/tests/one-step-parking/configs2/extensions.conf
<https://reviewboard.asterisk.org/r/811/#comment5507>

    Same as above comment, lets use the default settings to park (#72).



/asterisk/trunk/tests/one-step-parking/configs2/iax.conf
<https://reviewboard.asterisk.org/r/811/#comment5508>

    Is there a reason to disable this? I'd recommend we keep default functionality enabled.



/asterisk/trunk/tests/one-step-parking/configs2/iax.conf
<https://reviewboard.asterisk.org/r/811/#comment5509>

    same as above



/asterisk/trunk/tests/one-step-parking/configs2/logger.conf
<https://reviewboard.asterisk.org/r/811/#comment5510>

    Same comment as before


- pabelanger


On 2010-07-28 04:05:34, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 04:05:34)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "one step parking" top down test for asterisk:
> 
> userA calls userB
> userB parks userA by '*' - one step parking
> userB retrieves userA by calling 701
> - Test successful - 
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/one-step-parking/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/run-test PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 601 
> 
> Diff: https://reviewboard.asterisk.org/r/811/diff
> 
> 
> Testing
> -------
> 
> tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>