[asterisk-dev] [svn-commits] dvossel: trunk r280518 - /trunk/channels/chan_sip.c

[Olle E. Johansson]

29 jul 2010 kl. 21.35 skrev SVN commits to the Digium repositories:

> Author: dvossel
> Date: Thu Jul 29 14:35:34 2010
> New Revision: 280518
> 
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=280518
> Log:
> respond with 481 when request requiring totag has no totag to match against
> 
> Modified:
>    trunk/channels/chan_sip.c
> 
> Modified: trunk/channels/chan_sip.c
> URL: http://svnview.digium.com/svn/asterisk/trunk/channels/chan_sip.c?view=diff&rev=280518&r1=280517&r2=280518
> ==============================================================================
> --- trunk/channels/chan_sip.c (original)
> +++ trunk/channels/chan_sip.c Thu Jul 29 14:35:34 2010
> @@ -7334,6 +7334,7 @@
> 		}
> 		/* reject requests that must always have a To: tag */
> 		if (ast_strlen_zero(totag) && (req->method == SIP_ACK || req->method == SIP_BYE || req->method == SIP_INFO )) {
> +			transmit_response_using_temp(callid, addr, 1, intended_method, req, "481 Call leg/transaction does not exist");
> 			ast_debug(5, "%s must have a to tag. dropping callid: %s from: %s\n", sip_methods[req->method].text , callid, from );
> 			return NULL;
> 		}
> 
> 
Just checking - this code looks like it is responding to a SIP ACK. You NEVER EVER respond with ANYTHING to an ACK.

/O