[asterisk-dev] [Code Review] Top down test "blind transfer with parking timeout" GSOC 2010

[mnick at digium.com]

> On 2010-07-28 13:39:58, pabelanger wrote:
> > /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf, line 2
> > <https://reviewboard.asterisk.org/r/762/diff/1/?file=11411#file11411line2>
> >
> >     same as above, please strip

changed your suggestions ! Thank you !


> On 2010-07-28 13:39:58, pabelanger wrote:
> > /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/features.conf, line 2
> > <https://reviewboard.asterisk.org/r/762/diff/1/?file=11406#file11406line2>
> >
> >     Theses all look to be default settings that ship with Asterisk. You _should_ be able to remove this file.

the most important change is "parkingtime => 5", instead of 45 seconds.
I don't know if I should use the default features.conf or not ?!


- mnick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/762/#review2499
-----------------------------------------------------------


On 2010-07-29 08:22:11, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2010-07-29 08:22:11)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is "test 2": "blind transfer with parking timeout" of my GSOC project.
> 
> userA calls userB
> userB transfers userA by "#" -> "700"
> userA gets parked for 5 seconds and returns to userB due to parkingtimeout
> - Test successful -
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf 630 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/logger.conf 630 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf 630 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf 630 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test 630 
> 
> Diff: https://reviewboard.asterisk.org/r/762/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4, 1.6.0 and 1.6.2 (on a virtual machine, my real one got broken :( ... )
> 
> 
> Thanks,
> 
> mnick
> 
>