[asterisk-dev] [Code Review] Top down test "blind transfer with parking timeout" GSOC 2010

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/762/#review2499
-----------------------------------------------------------


Another peer review, good work.


/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/features.conf
<https://reviewboard.asterisk.org/r/762/#comment5511>

    Theses all look to be default settings that ship with Asterisk. You _should_ be able to remove this file.



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5512>

    Same comment as other test.  We should not be disabling this functionality.



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5513>

    same comment



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5514>

    whitespace



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/logger.conf
<https://reviewboard.asterisk.org/r/762/#comment5515>

    Please strip down



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5516>

    Whitespaces



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5517>

    Same as above



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5518>

    same as above



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf
<https://reviewboard.asterisk.org/r/762/#comment5519>

    whitespaces



/asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf
<https://reviewboard.asterisk.org/r/762/#comment5520>

    same as above, please strip


- pabelanger


On 2010-07-06 11:53:54, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2010-07-06 11:53:54)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is "test 2": "blind transfer with parking timeout" of my GSOC project.
> 
> userA calls userB
> userB transfers userA by "#" -> "700"
> userA gets parked for 5 seconds and returns to userB due to parkingtimeout
> - Test successful -
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 461 
> 
> Diff: https://reviewboard.asterisk.org/r/762/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4, 1.6.0 and 1.6.2 (on a virtual machine, my real one got broken :( ... )
> 
> 
> Thanks,
> 
> mnick
> 
>