[asterisk-dev] [Code Review] Expand MEETME_INFO() with new options

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/812/#review2490
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5489>

    You need to specify the unit of time in this description.  Seconds and milliseconds are both frequent units in Asterisk.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5494>

    Where is colname coming from?  It doesn't appear to be a local variable or a parameter to this function.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5495>

    How does this new keyword differ from the value of "activity", above?



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5497>

    With the addition of "markedusers", this error value needs to be rethought, because it's conceivable that there would be 0 markedusers in a conference.


- Tilghman


On 2010-07-28 05:01:46, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/812/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 05:01:46)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Simple patch that expands MEETME_INFO() with a few new options. 
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 280055 
> 
> Diff: https://reviewboard.asterisk.org/r/812/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olle E
> 
>