[asterisk-dev] [Code Review] Expand MEETME_INFO() with new options

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/812/#review2489
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5488>

    space after 1



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5490>

    You don't need 'now'.  Just call time(NULL) in your args to snprintf().  Also, look for other places where a time_t is used with a format string.  IIRC, this will produce a compiler warning on some systems.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment5492>

    It would be great to just convert this to an enum, but it doesn't have to be in this patch ....


- Russell


On 2010-07-28 05:01:46, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/812/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 05:01:46)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Simple patch that expands MEETME_INFO() with a few new options. 
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 280055 
> 
> Diff: https://reviewboard.asterisk.org/r/812/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olle E
> 
>