[asterisk-dev] [Code Review] External test for fastagi.controlStreamFile()

[Erin Spiceland]

> On 2010-07-26 12:02:01, Russell Bryant wrote:
> > /asterisk/trunk/tests/fastagi/control-stream-file/run-test, line 52
> > <https://reviewboard.asterisk.org/r/801/diff/2/?file=11900#file11900line52>
> >
> >     The parenthesis are not necessary.  Also, why not just change the code such that it will always be a string or an integer?

Yeah... that would be better. StarPy always sends a string for this particular function.


> On 2010-07-26 12:02:01, Russell Bryant wrote:
> > /asterisk/trunk/tests/fastagi/control-stream-file/run-test, line 62
> > <https://reviewboard.asterisk.org/r/801/diff/2/?file=11900#file11900line62>
> >
> >     I'd like to make all of our python code comply to PEP8 as best we can.  PEP8 specifies line length should be limited to 79 characters.

I was fixing that as you were posting this. :P


> On 2010-07-26 12:02:01, Russell Bryant wrote:
> > /asterisk/trunk/tests/fastagi/control-stream-file/run-test, line 119
> > <https://reviewboard.asterisk.org/r/801/diff/2/?file=11900#file11900line119>
> >
> >     by convention, I would call this main()

Copied this structure from another test. Will change.


> On 2010-07-26 12:02:01, Russell Bryant wrote:
> > /asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml, line 13
> > <https://reviewboard.asterisk.org/r/801/diff/2/?file=11901#file11901line13>
> >
> >     This dependency will never be met.  The type should be 'python' instead of 'app'.

Copied this as an example from another test. Will change.


- Erin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/801/#review2469
-----------------------------------------------------------


On 2010-07-26 11:48:21, Erin Spiceland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/801/
> -----------------------------------------------------------
> 
> (Updated 2010-07-26 11:48:21)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Self-explanatory. This test will always fail with StarPy 1.0.0a13 or older. Those versions expect Asterisk to send endpos, and Asterisk only sends it for STREAM FILE.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/configs/extensions.conf 584 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/801/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>