[asterisk-dev] [Code Review] External test for fastagi.controlStreamFile()

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/801/#review2469
-----------------------------------------------------------



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5444>

    The parenthesis are not necessary.  Also, why not just change the code such that it will always be a string or an integer?



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5445>

    There are a bunch of extra blank lines here.  :-)



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5447>

    I'd like to make all of our python code comply to PEP8 as best we can.  PEP8 specifies line length should be limited to 79 characters.



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5448>

    Since this is such a common construct, it seems like a good candidate for adding to the Asterisk class as a cli_originate() function or something.



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5449>

    by convention, I would call this main()



/asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml
<https://reviewboard.asterisk.org/r/801/#comment5443>

    This dependency will never be met.  The type should be 'python' instead of 'app'.


- Russell


On 2010-07-26 11:48:21, Erin Spiceland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/801/
> -----------------------------------------------------------
> 
> (Updated 2010-07-26 11:48:21)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Self-explanatory. This test will always fail with StarPy 1.0.0a13 or older. Those versions expect Asterisk to send endpos, and Asterisk only sends it for STREAM FILE.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/configs/extensions.conf 584 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/801/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>