[asterisk-dev] [Code Review] Dahdi FXS line polarity reversal when remote party Answers and/or Hangups

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/797/#review2451
-----------------------------------------------------------

Ship it!


Other than the quibble below, I do not see anything.  Although, I have not spent much time in sig_analog code.


trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/797/#comment5387>

    Curly braces since this is new code.


- rmudgett


On 2010-07-22 16:06:38, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/797/
> -----------------------------------------------------------
> 
> (Updated 2010-07-22 16:06:38)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Quoting armeniki:
> "FXS lines normally connect to a telephone. However, when FXS lines are routed to an external PBX or Key System to act as "external" or "CO" lines, it is extremely difficult, if not impossible for the external PBX to know when the call has been disconnected without receiving a polarity reversal on the line."
> 
> Implementation was to use existing keywords as used for FXO modules 'answeronpolityswitch' and 'hanguponpolarityswitch', with a similar function for the FXS module but from the Legacy PBX's point of view.
> 
> 
> This addresses bug 17318.
>     https://issues.asterisk.org/view.php?id=17318
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 278424 
>   trunk/channels/sig_analog.h 278424 
>   trunk/channels/sig_analog.c 278424 
> 
> Diff: https://reviewboard.asterisk.org/r/797/diff
> 
> 
> Testing
> -------
> 
> Using TDM800P FXS modules:
> 
> Inbound and outbound calls, using answeronpolarityswitch and hanguponpolarityswitch 
> 
> 
> Thanks,
> 
> Alec
> 
>