[asterisk-dev] [Code Review] Invert the objectname in the AMI answer of the iaxpeers
Olle E Johansson
oej at edvina.net
Fri Jul 16 05:19:17 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/789/#review2403
-----------------------------------------------------------
Ship it!
I have nothing to say about this more than that I don't think order for the various header/value pairs should not matter in AMI. But if it makes sense to you I have no problem changing this. Anyone else with an opinion?
- Olle E
On 2010-07-15 03:31:36, GMLudo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/789/
> -----------------------------------------------------------
>
> (Updated 2010-07-15 03:31:36)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> With this patch, the output of iaxpeers command has the same order as sippeers.
> It's useful for the AMI frameworks like Adhearsion, we can reuse the same parser for sippeers and iaxpeers.
>
>
> This addresses bug 17648.
> https://issues.asterisk.org/view.php?id=17648
>
>
> Diffs
> -----
>
> /trunk/channels/chan_iax2.c 276615
>
> Diff: https://reviewboard.asterisk.org/r/789/diff
>
>
> Testing
> -------
>
> Tested on our development server with the latest trunk version (r276571).
>
>
> Thanks,
>
> GMLudo
>
>
More information about the asterisk-dev
mailing list