[asterisk-dev] [svn-commits] mmichelson: branch mmichelson/acl-v6 r276826 - in /team/mmichelson/acl-v6: in...

[Olle E. Johansson]

> 
>    team/mmichelson/acl-v6/tests/test_acl.c
> 
> Modified: team/mmichelson/acl-v6/include/asterisk/acl.h
> URL: http://svnview.digium.com/svn/asterisk/team/mmichelson/acl-v6/include/asterisk/acl.h?view=diff&rev=276826&r1=276825&r2=276826
> ==============================================================================
> --- team/mmichelson/acl-v6/include/asterisk/acl.h (original)
> +++ team/mmichelson/acl-v6/include/asterisk/acl.h Thu Jul 15 16:20:55 2010
> @@ -51,6 +51,7 @@
> 	struct ast_sockaddr netmask;
> 	int sense;
> 	struct ast_ha *next;
> +	unsigned char is_ipv4;
> };

To make this really extensible, please make this a flag that stores the address family as an ENUM. That way we can extend ACLs to include other kind of addresses in the future. I don't see any immediate need, but I'm sure that bluetooth has some kind of addressing scheme, zap over ethernet has it's own and SS7, well who knows?
If we rebuild ACL to handle two kinds of addresses, we might as well be open for other additions. This community will provide us with the answer to the question "what?". :-)

/O