[asterisk-dev] [Code Review] ast_storage: public API, part of the odbc backend

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/773/#review2360
-----------------------------------------------------------



/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5217>

    I think this is actually missing two arguments:  an offset and a "whence" constant.



/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5218>

    We should note in the documentation that 'count' is in bytes ('characters' is ambiguous, since some characters can be multi-byte sequences).



/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5220>

    This should actually return type 'off_t'.



/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5219>

    Again, we need two more arguments for a seek.



/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5221>

    I don't know if we want to be specifying mode.  Our general policy is that our mode is always 0666, which can be narrowed based upon a umask set by the administrator.



/team/ivaxer/ast_storage/main/file.c
<https://reviewboard.asterisk.org/r/773/#comment5222>

    Add braces around statements following a conditional.



/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5223>

    Braces



/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5224>

    Braces



/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5225>

    Braces


- Tilghman


On 2010-07-11 23:10:00, ivaxer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/773/
> -----------------------------------------------------------
> 
> (Updated 2010-07-11 23:10:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ast_storage public API functions and create/release/get functions of the odbc storage backend
> 
> 
> Diffs
> -----
> 
>   /team/ivaxer/ast_storage/include/asterisk/file.h 262099 
>   /team/ivaxer/ast_storage/include/asterisk/storage.h PRE-CREATION 
>   /team/ivaxer/ast_storage/main/asterisk.c 262099 
>   /team/ivaxer/ast_storage/main/file.c 262099 
>   /team/ivaxer/ast_storage/main/storage.c PRE-CREATION 
>   /team/ivaxer/ast_storage/res/res_storage_odbc.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/773/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ivaxer
> 
>