[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

[Tilghman Lesher]

> On 2010-01-14 09:17:52, lmadsen wrote:
> > /trunk/configs/cdr_odbc.conf.sample, line 13
> > <https://reviewboard.asterisk.org/r/461/diff/1/?file=7648#file7648line13>
> >
> >     I think you should add a comment here describing what hrtime is for.
> >     
> >     ;hrtime=yes      ; enable high resolution time for logging time with fractions of a second
> >     
> >     
> >     (is this being done in milliseconds...?)
> 
> Brad Latus wrote:
>     Milliseconds should be good enough, but I have not set a limit. 
>     AKA limiting CDR() function to output x.yyy (%.3lf) instead of whatever big value it might do currently.

6 decimal places is the maximum.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/#review1362
-----------------------------------------------------------


On 2010-01-14 05:56:29, Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2010-01-14 05:56:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This allows for the showing of the accurate times for billable time and call duration.
> Adds new flag to CDR function 'f' for the above fields.
> 
> This came about by bug #16559 and I thought i'd take a go at making it happen.
> 
> We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)
> 
> 
> This addresses bug 16559.
>     https://issues.asterisk.org/view.php?id=16559
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 238312 
>   /trunk/UPGRADE.txt 238312 
>   /trunk/addons/cdr_mysql.c 238312 
>   /trunk/cdr/cdr_adaptive_odbc.c 238312 
>   /trunk/cdr/cdr_odbc.c 238312 
>   /trunk/cdr/cdr_sqlite.c 238312 
>   /trunk/cdr/cdr_sqlite3_custom.c 238312 
>   /trunk/cdr/cdr_tds.c 238312 
>   /trunk/configs/cdr_custom.conf.sample 238312 
>   /trunk/configs/cdr_odbc.conf.sample 238312 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 238312 
>   /trunk/configs/cdr_syslog.conf.sample 238312 
>   /trunk/configs/cdr_tds.conf.sample 238312 
>   /trunk/funcs/func_cdr.c 238312 
> 
> Diff: https://reviewboard.asterisk.org/r/461/diff
> 
> 
> Testing
> -------
> 
> Compile test only.
> 
> 
> Thanks,
> 
> Brad
> 
>