[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/#review1365
-----------------------------------------------------------



/trunk/addons/cdr_mysql.c
<https://reviewboard.asterisk.org/r/461/#comment3106>

    It appears MySQL also supports "numeric"



/trunk/cdr/cdr_odbc.c
<https://reviewboard.asterisk.org/r/461/#comment3107>

    SQL_FLOAT actually corresponds to SQL_C_DOUBLE.  See http://publib.boulder.ibm.com/infocenter/dzichelp/v2r2/index.jsp?topic=/com.ibm.db2.doc.odbc/bjneappl1009305.htm
    
    Also, the second parameter should be 9 for the first line.



/trunk/cdr/cdr_sqlite.c
<https://reviewboard.asterisk.org/r/461/#comment3108>

    I think I'd prefer if you didn't indent the preprocessor keywords here.  The only time that we really do that in Asterisk is when we embed preprocessor conditionals in other conditionals.


- Tilghman


On 2010-01-14 05:56:29, Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2010-01-14 05:56:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This allows for the showing of the accurate times for billable time and call duration.
> Adds new flag to CDR function 'f' for the above fields.
> 
> This came about by bug #16559 and I thought i'd take a go at making it happen.
> 
> We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)
> 
> 
> This addresses bug 16559.
>     https://issues.asterisk.org/view.php?id=16559
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 238312 
>   /trunk/UPGRADE.txt 238312 
>   /trunk/addons/cdr_mysql.c 238312 
>   /trunk/cdr/cdr_adaptive_odbc.c 238312 
>   /trunk/cdr/cdr_odbc.c 238312 
>   /trunk/cdr/cdr_sqlite.c 238312 
>   /trunk/cdr/cdr_sqlite3_custom.c 238312 
>   /trunk/cdr/cdr_tds.c 238312 
>   /trunk/configs/cdr_custom.conf.sample 238312 
>   /trunk/configs/cdr_odbc.conf.sample 238312 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 238312 
>   /trunk/configs/cdr_syslog.conf.sample 238312 
>   /trunk/configs/cdr_tds.conf.sample 238312 
>   /trunk/funcs/func_cdr.c 238312 
> 
> Diff: https://reviewboard.asterisk.org/r/461/diff
> 
> 
> Testing
> -------
> 
> Compile test only.
> 
> 
> Thanks,
> 
> Brad
> 
>