[asterisk-dev] [Code Review] parkinglots with different parking extensions

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/417/#review1347
-----------------------------------------------------------


Make sure to decrement the ref of ao2 objects when you're looping through a iterator, there is some minor coding guideline stuff here too.


/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3087>

    what is happening to the ref here for the parkinglot if this returns?. (I'm talking about the line right below this one, clicked the wrong one.)



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3088>

    move the unref below the if statement.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3089>

    curlot needs needs some unrefing 



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3082>

    curlot refs need to be accounted for here



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3081>

    add brackets to the if statement.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3083>

    coding guidelines, add spaces here and next line



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3084>

    space before '{'



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3085>

    space before '{' here and next line



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/417/#comment3086>

    space before '{'


- David


On 2010-01-06 15:59:41, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/417/
> -----------------------------------------------------------
> 
> (Updated 2010-01-06 15:59:41)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In features.conf you can define one parking extension: for example
> [general]
> parkext = 700
> parkpos = 701-750
> ...
> 
> you can also define new parkinglots like:
> [parkinglot_park2]
> context = park2
> parkpos = 801 - 850
> 
> but it is not possible to set a new 'parkext' to 'parkinglot_park2' (like: parkext = 800)
> 
> 
> Now it should be possible to have more than one parking extension. 
> [parkinglot_park2]
> parkext = 800
> parkpos = 801 - 850
> context = park2
> 
> [parkinglot_sales]
> parkext = 900
> parkpos = 901 - 950
> context = sales
> 
> 
> [Please ignore the 'my_dump_chan()' and 'my_dump_parkinglot()' functions, they're just for testing]
> 
> 
> This addresses bug 14882.
>     https://issues.asterisk.org/view.php?id=14882
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 235813 
> 
> Diff: https://reviewboard.asterisk.org/r/417/diff
> 
> 
> Testing
> -------
> 
> I have tried various scenario's with different parkinglot's and context's. 
> But I am not sure if I've covered all cases.
> 
> 
> Thanks,
> 
> mnick
> 
>