[asterisk-dev] [Code Review] parkinglots with different parking extensions

[mnick at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/417/
-----------------------------------------------------------

(Updated 2010-01-06 15:59:41.043534)


Review request for Asterisk Developers.


Changes
-------

made some changes which refer to 'features reload'.
The behaviour of how the parkinglots get created and destroyed has changed and improved.
Parking extensions and parking contexts are more consistent after changes and reloads.
Added a new structure which contains all the global variables (struct global_settings)


Summary
-------

In features.conf you can define one parking extension: for example
[general]
parkext = 700
parkpos = 701-750
...

you can also define new parkinglots like:
[parkinglot_park2]
context = park2
parkpos = 801 - 850

but it is not possible to set a new 'parkext' to 'parkinglot_park2' (like: parkext = 800)


Now it should be possible to have more than one parking extension. 
[parkinglot_park2]
parkext = 800
parkpos = 801 - 850
context = park2

[parkinglot_sales]
parkext = 900
parkpos = 901 - 950
context = sales


[Please ignore the 'my_dump_chan()' and 'my_dump_parkinglot()' functions, they're just for testing]


This addresses bug 14882.
    https://issues.asterisk.org/view.php?id=14882


Diffs (updated)
-----

  /trunk/main/features.c 235813 

Diff: https://reviewboard.asterisk.org/r/417/diff


Testing
-------

I have tried various scenario's with different parkinglot's and context's. 
But I am not sure if I've covered all cases.


Thanks,

mnick