[asterisk-dev] [Code Review] base64 unit test
David Vossel
dvossel at digium.com
Fri Feb 26 17:42:10 CST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/533/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
A simple base64 unit test that completely rips off the sha1_test's test input :)
I noticed that the test was failing because the ast_base64decoded wasn't terminating the buffer with a '\0'. This almost looked intentional, but I don't understand why we would want it to work like this so I fixed it.
Diffs
-----
/trunk/main/utils.c 249231
/trunk/tests/test_utils.c 249231
Diff: https://reviewboard.asterisk.org/r/533/diff
Testing
-------
ran tests, it works.
Thanks,
David
More information about the asterisk-dev
mailing list