[asterisk-dev] [Code Review] New dialplan application VMSayname with unit test

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/530/
-----------------------------------------------------------

(Updated 2010-02-26 13:44:09.540578)


Review request for Asterisk Developers.


Changes
-------

Addressed David's stylistic concerns and removed some stupid stuff per advice of Mark.


Summary
-------

This patch adds a new application, VMSayName, which plays the greeting for a given voicemail user specified by extension and optionally context. If the greeting does not exist, currently the extension is played back.


This addresses bug 14973.
    https://issues.asterisk.org/view.php?id=14973


Diffs (updated)
-----

  /trunk/apps/app_voicemail.c 249231 

Diff: https://reviewboard.asterisk.org/r/530/diff


Testing
-------

A unit test has been created to test the code paths used for playback in the case when the greeting is present and when it is not. Because the application is really just a wrapper function, the unit test is what needs to be examined more so than anything else.


Thanks,

Jeff