[asterisk-dev] [Code Review] Doxygen for acl.h: 1.4 branch

[Mark Michelson]

> On 2010-02-25 08:51:03, Leif Madsen wrote:
> > /branches/1.4/include/asterisk/acl.h, line 63
> > <https://reviewboard.asterisk.org/r/528/diff/1/?file=8270#file8270line63>
> >
> >     Perhaps you could put single quotes around 'to HA' and 'from HA' to make this a little more readable?

Sounds good. Will do.


> On 2010-02-25 08:51:03, Leif Madsen wrote:
> > /branches/1.4/include/asterisk/acl.h, line 103
> > <https://reviewboard.asterisk.org/r/528/diff/1/?file=8270#file8270line103>
> >
> >     Extra space in the word "socket"

Heh, using the term "Internet socket address" seems weird here to me now anyway. I'll probably just use sockaddr_in instead.


> On 2010-02-25 08:51:03, Leif Madsen wrote:
> > /branches/1.4/include/asterisk/acl.h, line 148
> > <https://reviewboard.asterisk.org/r/528/diff/1/?file=8270#file8270line148>
> >
> >     Always port 5060? Or is this configurable somewhere?

This is not configurable.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/528/#review1595
-----------------------------------------------------------


On 2010-02-24 10:06:48, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/528/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 10:06:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I began to write a unit test for ACLs in Asterisk trunk recently, but I had a hard time because there was absolutely no doxygen at all for the various ACL functions. I decided that a good first step would be to add doxygen to all ACL functions first and then write the unit test.
> 
> Note that I have attached here the 1.4 version of the doxygen. The versions for the other branches aren't much different. There is one extra function in Asterisk trunk (ast_str2cos) and the ast_append_ha function has one extra parameter. Other than that, the functions are all the same between all the branches and work the same way.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/include/asterisk/acl.h 247166 
> 
> Diff: https://reviewboard.asterisk.org/r/528/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark
> 
>