[asterisk-dev] [Code Review] Voicemail check cleanup

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/525/
-----------------------------------------------------------

(Updated 2010-02-24 10:04:10.778541)


Review request for Asterisk Developers.


Changes
-------

Add unit test, which helped find and fix at least one issue in my code.  Also addressed Mark's suggestions.


Summary
-------

A few cleanups to fix a few bugs.

- Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
- Urgent voicemails were sometimes counted twice when displaying the count of new messages.
- Backends were inconsistent as to which voicemails each API counted.


This addresses bugs 15654 and 16448.
    https://issues.asterisk.org/view.php?id=15654
    https://issues.asterisk.org/view.php?id=16448


Diffs (updated)
-----

  /trunk/apps/app_voicemail.c 248394 

Diff: https://reviewboard.asterisk.org/r/525/diff


Testing
-------

Working on it; wanted to get the code reviewed while testing commenced.


Thanks,

Tilghman