[asterisk-dev] [Code Review] Voicemail check cleanup

[Mark Michelson]

> On 2010-02-23 13:04:53, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, line 2268
> > <https://reviewboard.asterisk.org/r/525/diff/1/?file=8262#file8262line2268>
> >
> >     After taking a closer look, I'm not sure what this change helps.
> 
> Tilghman Lesher wrote:
>     The standard format for separating mailbox numbers is the '&', not the ','.  In this case, this is a fix to make the function consistent with the API calls for other storage backends.

All right, I understand. If you're going to make this change, then you need to also change the if statement that precedes this while to also check for the presence of an ampersand. It currently only looks for a comma.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/525/#review1558
-----------------------------------------------------------


On 2010-02-23 12:35:17, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/525/
> -----------------------------------------------------------
> 
> (Updated 2010-02-23 12:35:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A few cleanups to fix a few bugs.
> 
> - Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
> - Urgent voicemails were sometimes counted twice when displaying the count of new messages.
> - Backends were inconsistent as to which voicemails each API counted.
> 
> 
> This addresses bugs 15654 and 16448.
>     https://issues.asterisk.org/view.php?id=15654
>     https://issues.asterisk.org/view.php?id=16448
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 248394 
>   /trunk/include/asterisk/app.h 248394 
>   /trunk/res/res_agi.c 248394 
> 
> Diff: https://reviewboard.asterisk.org/r/525/diff
> 
> 
> Testing
> -------
> 
> Working on it; wanted to get the code reviewed while testing commenced.
> 
> 
> Thanks,
> 
> Tilghman
> 
>