[asterisk-dev] [Code Review] Voicemail check cleanup

[Tilghman Lesher]

> On 2010-02-23 13:03:13, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, lines 2034-2035
> > <https://reviewboard.asterisk.org/r/525/diff/1/?file=8262#file8262line2034>
> >
> >     When using IMAP voicemail, care should be taken to avoid using "INBOX" explicitly. The reason is that the folder in which to store new messages is configurable with the imapfolder option in voicemail.conf. In this case, for a user who is not using INBOX to store new messages, messagecount will not properly tell the number of new messages.

In this case, though, this is a public API call, and callers will not necessarily obey such a restriction.  The case for dealing with the "INBOX" folder is, in fact, handled within the __messagecount function, which is the real workhorse.  This function is just the syntactic equivalent to ensuring that the result takes into account both Urgent, as well as non-Urgent messages.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/525/#review1557
-----------------------------------------------------------


On 2010-02-23 12:35:17, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/525/
> -----------------------------------------------------------
> 
> (Updated 2010-02-23 12:35:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A few cleanups to fix a few bugs.
> 
> - Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
> - Urgent voicemails were sometimes counted twice when displaying the count of new messages.
> - Backends were inconsistent as to which voicemails each API counted.
> 
> 
> This addresses bugs 15654 and 16448.
>     https://issues.asterisk.org/view.php?id=15654
>     https://issues.asterisk.org/view.php?id=16448
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 248394 
>   /trunk/include/asterisk/app.h 248394 
>   /trunk/res/res_agi.c 248394 
> 
> Diff: https://reviewboard.asterisk.org/r/525/diff
> 
> 
> Testing
> -------
> 
> Working on it; wanted to get the code reviewed while testing commenced.
> 
> 
> Thanks,
> 
> Tilghman
> 
>