[asterisk-dev] [Code Review] Voicemail check cleanup

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/525/#review1557
-----------------------------------------------------------


In addition to the comment below, the res_agi changes are not relevant to these bugfixes. Other than that, it looks pretty good!


/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/525/#comment3487>

    When using IMAP voicemail, care should be taken to avoid using "INBOX" explicitly. The reason is that the folder in which to store new messages is configurable with the imapfolder option in voicemail.conf. In this case, for a user who is not using INBOX to store new messages, messagecount will not properly tell the number of new messages.


- Mark


On 2010-02-23 12:35:17, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/525/
> -----------------------------------------------------------
> 
> (Updated 2010-02-23 12:35:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A few cleanups to fix a few bugs.
> 
> - Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
> - Urgent voicemails were sometimes counted twice when displaying the count of new messages.
> - Backends were inconsistent as to which voicemails each API counted.
> 
> 
> This addresses bugs 15654 and 16448.
>     https://issues.asterisk.org/view.php?id=15654
>     https://issues.asterisk.org/view.php?id=16448
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 248394 
>   /trunk/include/asterisk/app.h 248394 
>   /trunk/res/res_agi.c 248394 
> 
> Diff: https://reviewboard.asterisk.org/r/525/diff
> 
> 
> Testing
> -------
> 
> Working on it; wanted to get the code reviewed while testing commenced.
> 
> 
> Thanks,
> 
> Tilghman
> 
>