[asterisk-dev] [Code Review] Make the parameter separator backward compatible, and error messages more consistent.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/79/#review1570
-----------------------------------------------------------

Ship it!


This may not exactly touch every single case where a hardcoded ',' is used in the code, but committing this as-is is an excellent start and at least will give a suitable template for how future coding should be done. Great job, Eliel, and sorry no one looked at this sooner.

- Mark


On 2009-04-23 11:27:34, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/79/
> -----------------------------------------------------------
> 
> (Updated 2009-04-23 11:27:34)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch implements an asterisk.conf [compat] option called app_delim, to make applications and functions parameter delimiter backward compatible. if app_delim < 1.5 then, then app/fun delimited should be | (pipe), otherwise it should be "," comma.
> Also there are a number of functions that where not using STANDARD_APP_ARG to parse the app/fun parameters, so, that was changed to use AST_STANDARD_APP_DELIM.
> When printing error messages, we where printing the "syntax" with a hardcoded parameter separator, now the syntax being printed is the one generated with the xml documentation, so the error messages will be consistent with the actual parameter separator, and also with the actual app/fun syntax.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 190216 
>   /trunk/apps/app_exec.c 190216 
>   /trunk/apps/app_macro.c 190216 
>   /trunk/apps/app_meetme.c 190216 
>   /trunk/apps/app_page.c 190216 
>   /trunk/apps/app_queue.c 190216 
>   /trunk/apps/app_readfile.c 190216 
>   /trunk/apps/app_stack.c 190216 
>   /trunk/apps/app_voicemail.c 190216 
>   /trunk/funcs/func_callerid.c 190216 
>   /trunk/funcs/func_cut.c 190216 
>   /trunk/funcs/func_env.c 190216 
>   /trunk/funcs/func_realtime.c 190216 
>   /trunk/funcs/func_strings.c 190216 
>   /trunk/include/asterisk/app.h 190216 
>   /trunk/include/asterisk/pbx.h 190216 
>   /trunk/main/features.c 190216 
>   /trunk/main/pbx.c 190216 
>   /trunk/main/xmldoc.c 190216 
>   /trunk/pbx/pbx_lua.c 190216 
>   /trunk/res/res_agi.c 190216 
> 
> Diff: https://reviewboard.asterisk.org/r/79/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>