[asterisk-dev] [Code Review] Missing T.38 -> audio fall back function for 1.4

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/514/#review1565
-----------------------------------------------------------


I can't really see anything objectionable with this patch as it is. The only thing that worries me is that the "Testing done" section is completely empty. What testing has been done so far?

- Mark


On 2010-02-17 04:42:45, vrban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/514/
> -----------------------------------------------------------
> 
> (Updated 2010-02-17 04:42:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When a T.38 re-INVITE failed with an 488 or 606 answer, we should fallback to audio fax by sending a re-re-INVITE with audio.
> 
> 
> This addresses bug 16692.
>     https://issues.asterisk.org/view.php?id=16692
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 246298 
> 
> Diff: https://reviewboard.asterisk.org/r/514/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> vrban
> 
>