[asterisk-dev] [Code Review] astobj2 unit test

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/496/#review1492
-----------------------------------------------------------


getting close!


/trunk/tests/test_astobj2.c
<https://reviewboard.asterisk.org/r/496/#comment3367>

    copy paste error in the string



/trunk/tests/test_astobj2.c
<https://reviewboard.asterisk.org/r/496/#comment3368>

    What if ao2_t_alloc() fails?



/trunk/tests/test_astobj2.c
<https://reviewboard.asterisk.org/r/496/#comment3369>

    is this an AST_TEST_FAIL condition?



/trunk/tests/test_astobj2.c
<https://reviewboard.asterisk.org/r/496/#comment3370>

    This looks weird ... How about just:
    
    if ((obj = ao2_find())) {
    ...
    }


- Russell


On 2010-02-10 10:48:08, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/496/
> -----------------------------------------------------------
> 
> (Updated 2010-02-10 10:48:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a unit test for main/astobj2.c.  All the status update calls will be changed to match Russell's tweak once it is committed.  That is why I do not set the error string anywhere.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/astobj2.c 246052 
>   /trunk/tests/test_astobj2.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/496/diff
> 
> 
> Testing
> -------
> 
> ran unit test, verified it passes. 
> 
> 
> Thanks,
> 
> David
> 
>