[asterisk-dev] [Code Review] astobj2 unit test

David Vossel dvossel at digium.com
Wed Feb 10 10:48:08 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/496/
-----------------------------------------------------------

(Updated 2010-02-10 10:48:08.273736)


Review request for Asterisk Developers.


Changes
-------

UPDATE: addresses Russell's comments and fixes an astobj2 memory leak when (OBJ_MULTIPLE | OBJ_UNLINK) is used.


Summary
-------

This is a unit test for main/astobj2.c.  All the status update calls will be changed to match Russell's tweak once it is committed.  That is why I do not set the error string anywhere.


Diffs (updated)
-----

  /trunk/main/astobj2.c 246052 
  /trunk/tests/test_astobj2.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/496/diff


Testing
-------

ran unit test, verified it passes. 


Thanks,

David




More information about the asterisk-dev mailing list