[asterisk-dev] [Code Review] Add Congestion detail in CDR call logs when Congestion application is used.

[Alec Davis]

> On 2010-02-02 11:47:26, Terry Wilson wrote:
> > By default, Asterisk does not record unanswered calls in the CDR log. In cdr.conf, if you set unanswered=yes, you will see a "NO ANSWER" result in the cdr. If anything else was required, I would think that modifying pbx_builtin_congestion to call ast_cdr_failed() would suffice as opposed to adding a whole new CDR disposition.

cdr.conf as you say requires unanswered=yes, which from the cdr.conf file
"Some find this information horribly useless. Others find it very valuable."

Many sites would be running with unanswered=no.


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/454/#review1437
-----------------------------------------------------------


On 2010-01-07 12:45:17, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/454/
> -----------------------------------------------------------
> 
> (Updated 2010-01-07 12:45:17)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Cuurently if the dialplan is designed for whatever reason to terminate a call with the Congestion() application a CDR log is not recorded for that call.
> 
> This adds that functionality.
> 
> 
> This addresses bug 15907.
>     https://issues.asterisk.org/view.php?id=15907
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/cdr.h 237965 
>   trunk/main/cdr.c 237965 
>   trunk/main/pbx.c 237965 
> 
> Diff: https://reviewboard.asterisk.org/r/454/diff
> 
> 
> Testing
> -------
> 
> Tested and currently been in use with 1.6.1 branch.
> 
> Tested for functionality with trunk.
> 
> dialplan:
> exten => 2001,1,Congestion(0)
> exten => 2098,1,Playback(echo-test)
> 
> output: /var/log/asterisk/cdr-csv/Master.csv for 2 calls, first to Playback application, 2nd to Congestion(). 
> "","857","2098","phones","857","SIP/cisco4-00000000","","Playback","echo-test","2010-01-06 20:47:45","2010-01-06 20:47:45","2010-01-06 20:47:47",2,2,"ANSWERED","DOCUMENTATION","1262764065.2",""
> "","857","2001","phones","857","SIP/cisco4-00000000","","Congestion","0","2010-01-06 20:50:09",,"2010-01-06 20:50:09",0,0,"CONGESTION","DOCUMENTATION","1262764209.0",""
> 
> 
> Thanks,
> 
> Alec
> 
>