[asterisk-dev] [Code Review] FeatureDetected AMI event

Olle E Johansson reviewboard at asterisk.org
Wed Dec 22 20:57:38 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1065/#review3064
-----------------------------------------------------------


Be careful with the word "Peer". People expect it to be something else. We have many examples of secondary channels, try to get inspiration from them.

Also, this has to be configurable. In some configurations, this event might overload an app. Maybe even per event.

Otherwise, a nice idea. 

- Olle E


On 2010-12-22 13:21:53, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1065/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 13:21:53)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A simple patch to detect when a DTMF feature from the AMI. Feedback on the event name is requested :)
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 299001 
>   trunk/main/features.c 299001 
> 
> Diff: https://reviewboard.asterisk.org/r/1065/diff
> 
> 
> Testing
> -------
> 
> Local dev box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101222/3653fc28/attachment.htm>


More information about the asterisk-dev mailing list