[asterisk-dev] [Code Review] New Media Architecture phase 1 step 1

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1062/#review3051
-----------------------------------------------------------



/trunk/main/format.c
<https://reviewboard.asterisk.org/r/1062/#comment6270>

    I've been thinking about this more.  Using an ao2 container to hold the format interfaces will provide fast look up, but the problem is that every look up requires a lock on the ao2 container.  This means while the interface will be found very fast, if multiple calls are up requiring the same interface to be found for EVERY single audio frame that comes in, this mutually exclusive interface look up is a huge bottleneck.
    
    Something else will have to be done here.


- David


On 2010-12-17 15:51:34, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1062/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 15:51:34)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Here is what I am working on. https://wiki.asterisk.org/wiki/display/AST/Media+Architecture+Proposal
> 
> This is phase 1 step 1 of that proposal.
> 
> Below is everything that is included in this review.
> 
> Step 1
>     * Define new format unique ID system using numbers rather than bits. Allow this definition to remain unused during this step except by the new APIs.
>     * Create Ast Format API + unit tests.
>     * Create Ast Capibility API + unit tests.
>     * Create IAX2 Conversion layer for ast_format and ast_cap objects. Create unit tests and leave this layer inactive until conversion to new APIs takes place.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/format.h PRE-CREATION 
>   /trunk/include/asterisk/format_cap.h PRE-CREATION 
>   /trunk/main/format.c PRE-CREATION 
>   /trunk/main/format_cap.c PRE-CREATION 
>   /trunk/tests/test_format_api.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1062/diff
> 
> 
> Testing
> -------
> 
> Unit tests are included.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101220/3b9cffad/attachment.htm>