[asterisk-dev] Fwd: [Code Review] Issue 18243: Update initial state of hints when new device state provider registers

[Olle E. Johansson]

A kind reminder.

Have a nice weekend.

/O :-)

Vidarebefordrat brev:

> Från: "Olle E Johansson" <reviewboard at asterisk.org>
> Datum: 4 december 2010 13.59.52 CET
> Till: "Olle E Johansson" <oej at edvina.net>, "Olle E Johansson" <reviewboard at asterisk.org>, "Asterisk Developers" <asterisk-dev at lists.digium.com>
> Ämne: [asterisk-dev] [Code Review] Issue 18243: Update initial state of hints when new device state provider registers
> Svara till: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com>
> 
> This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1048/
> 
> Review request for Asterisk Developers.
> By Olle E Johansson.
> Description
> 
> When the dialplan loads, all hints are initialized to a first state. If a device state provider is not loaded at the time, like meetme (or the new device state provider in chan_sip/Pinana), the hints are not initialized to the initial state. This affects all hints that have an initial state, like a registration in chan_sip, which is a state for "presence" subscriptions using SIMPLE in chan_sip.
> 
> The patch in /svn/asterisk/team/oej/pinana-initialize-devstate-1.4 fixes this by re-initializing all hints using the new device state provider after registration of a new device state provider.
> Testing
> 
> Testing done while testing Pinana, which adds a new device state provider for remote sip states. Without this patch, the device state provider hints would never initialize properly when ASterisk starts, since the dialplan loads before chan_sip.
> Bugs: 18243
> Diffs
> 
> /team/oej/pinana-initialize-devstate-1.4/include/asterisk/pbx.h (297578)
> /team/oej/pinana-initialize-devstate-1.4/main/devicestate.c (297578)
> /team/oej/pinana-initialize-devstate-1.4/main/pbx.c (297578)
> View Diff
> 
> -- 
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101211/c0782c2f/attachment.htm