[asterisk-dev] [Code Review] Issue 18243: Update initial state of hints when new device state provider registers

Olle E Johansson reviewboard at asterisk.org
Sat Dec 4 12:59:52 UTC 2010

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.


When the dialplan loads, all hints are initialized to a first state. If a device state provider is not loaded at the time, like meetme (or the new device state provider in chan_sip/Pinana), the hints are not initialized to the initial state. This affects all hints that have an initial state, like a registration in chan_sip, which is a state for "presence" subscriptions using SIMPLE in chan_sip.

The patch in /svn/asterisk/team/oej/pinana-initialize-devstate-1.4 fixes this by re-initializing all hints using the new device state provider after registration of a new device state provider.

This addresses bug 18243.


  /team/oej/pinana-initialize-devstate-1.4/include/asterisk/pbx.h 297578 
  /team/oej/pinana-initialize-devstate-1.4/main/devicestate.c 297578 
  /team/oej/pinana-initialize-devstate-1.4/main/pbx.c 297578 

Diff: https://reviewboard.asterisk.org/r/1048/diff


Testing done while testing Pinana, which adds a new device state provider for remote sip states. Without this patch, the device state provider hints would never initialize properly when ASterisk starts, since the dialplan loads before chan_sip.


Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101204/352013e1/attachment-0001.htm 

More information about the asterisk-dev mailing list