[asterisk-dev] [Code Review] optimize fastagi tests.

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1045/
-----------------------------------------------------------

(Updated 2010-12-03 15:01:27.270635)


Review request for Asterisk Developers.


Changes
-------

v3: This removes all logic around cli_alias.conf.  After brainstorming with Russell we decided to not use it, however a test can be written for it.


Summary (updated)
-------

I've reworked the fastagi tests, increasing performance on FreeBSD from 22mins to 2mins.   Most of the issues revolved around static timeouts within the tests, I've removed them in favor of dynamic timeouts.  I've also move starting / stopping outside the scope of the tests as the test should NOT depend on Asterisk starting or stopping. 


Diffs (updated)
-----

  asterisk/trunk/tests/fastagi/channel-status/run-test 1055 
  asterisk/trunk/tests/fastagi/configs/ast1/extensions.conf 1055 
  asterisk/trunk/tests/fastagi/connect/run-test 1055 
  asterisk/trunk/tests/fastagi/control-stream-file/run-test 1055 
  asterisk/trunk/tests/fastagi/database/run-test 1055 
  asterisk/trunk/tests/fastagi/execute/run-test 1055 
  asterisk/trunk/tests/fastagi/get-data/run-test 1055 
  asterisk/trunk/tests/fastagi/hangup/run-test 1055 
  asterisk/trunk/tests/fastagi/record-file/run-test 1055 
  asterisk/trunk/tests/fastagi/say-alpha/run-test 1055 
  asterisk/trunk/tests/fastagi/say-date/run-test 1055 
  asterisk/trunk/tests/fastagi/say-datetime/run-test 1055 
  asterisk/trunk/tests/fastagi/say-digits/run-test 1055 
  asterisk/trunk/tests/fastagi/say-number/run-test 1055 
  asterisk/trunk/tests/fastagi/say-phonetic/run-test 1055 
  asterisk/trunk/tests/fastagi/say-time/run-test 1055 
  asterisk/trunk/tests/fastagi/stream-file/run-test 1055 
  asterisk/trunk/tests/fastagi/tests.yaml 1055 
  asterisk/trunk/tests/fastagi/wait-for-digit/run-test 1055 

Diff: https://reviewboard.asterisk.org/r/1045/diff


Testing
-------

Local box, and slow FreeBSD system.  Both passed.

Asterisk 1.4 and trunk.


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101203/2c1bebe4/attachment-0001.htm