<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1045/">https://reviewboard.asterisk.org/r/1045/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-03 15:01:27.270635</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">v3: This removes all logic around cli_alias.conf. After brainstorming with Russell we decided to not use it, however a test can be written for it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've reworked the fastagi tests, increasing performance on FreeBSD from 22mins to 2mins. Most of the issues revolved around static timeouts within the tests, I've removed them in favor of dynamic timeouts. I've also move starting / stopping outside the scope of the tests as the test should NOT depend on Asterisk starting or stopping. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local box, and slow FreeBSD system. Both passed.
Asterisk 1.4 and trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/configs/ast1/extensions.conf <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/tests.yaml <span style="color: grey">(1055)</span></li>
<li>asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(1055)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>