[asterisk-dev] [Code Review] Top down test "one step parking" GSOC 2010

[mnick at digium.com]

> On 2010-08-16 10:48:10, Russell Bryant wrote:
> > /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test, lines 120-121
> > <https://reviewboard.asterisk.org/r/811/diff/3/?file=12264#file12264line120>
> >
> >     I would break this up as:
> >     
> >     self.asterisk1.cli_originate(
> >         "IAX2/..........."
> >     )

thanks Russell, cleaned the code.


- mnick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/811/#review2607
-----------------------------------------------------------


On 2010-08-16 14:16:09, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-08-16 14:16:09)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "one step parking" top down test for asterisk:
> 
> userA calls userB
> userB parks userA by '*' - one step parking
> userB retrieves userA by calling 701
> - Test successful - 
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test 730 
> 
> Diff: https://reviewboard.asterisk.org/r/811/diff
> 
> 
> Testing
> -------
> 
> tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>