[asterisk-dev] [Code Review] Top down test "one step parking" GSOC 2010

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/811/#review2607
-----------------------------------------------------------

Ship it!



/asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5696>

    The \ isn't necessary, since the line break is in between ( ).



/asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5697>

    I would break this up as:
    
    self.asterisk1.cli_originate(
        "IAX2/..........."
    )


- Russell


On 2010-08-15 16:43:43, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-08-15 16:43:43)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "one step parking" top down test for asterisk:
> 
> userA calls userB
> userB parks userA by '*' - one step parking
> userB retrieves userA by calling 701
> - Test successful - 
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/one-step-parking/run-test 720 
> 
> Diff: https://reviewboard.asterisk.org/r/811/diff
> 
> 
> Testing
> -------
> 
> tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>