[asterisk-dev] [Code Review] Remove MP3 decoder source code from main Asterisk source tree

[Sean Bright]

> On 2010-08-03 14:03:42, Sean Bright wrote:
> > /branches/1.8/contrib/scripts/get_mp3_source.sh, line 12
> > <https://reviewboard.asterisk.org/r/836/diff/2/?file=12085#file12085line12>
> >
> >     What's the harm in just rolling whatever we have into a tarball?  This code rarely (if ever) changes.
> 
> Russell Bryant wrote:
>     Nothing ... this was just quicker for me to do, I guess.  Laziness?

Well when you put it that way... Ship it!


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/836/#review2521
-----------------------------------------------------------


On 2010-08-03 13:46:58, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/836/
> -----------------------------------------------------------
> 
> (Updated 2010-08-03 13:46:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change was inspired by the following thread on the asterisk-dev mailing list:
> 
> "Asterisk 1.8 and MP3 code?"
> http://lists.digium.com/pipermail/asterisk-dev/2010-August/045532.html
> 
> This patch removes the MP3 decoder source code from the Asterisk tree.  The wrapper, format_mp3.c, remains.  However, to build it, a script must be run that downloads the source code from another location.  Also, if format_mp3 is enabled, but the source has not been downloaded, the Makefile will print out instructions on how to go get it.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/addons/Makefile 280737 
>   /branches/1.8/addons/mp3/MPGLIB_README 280737 
>   /branches/1.8/addons/mp3/MPGLIB_TODO 280737 
>   /branches/1.8/addons/mp3/Makefile 280737 
>   /branches/1.8/addons/mp3/README 280737 
>   /branches/1.8/addons/mp3/common.c 280737 
>   /branches/1.8/addons/mp3/dct64_i386.c 280737 
>   /branches/1.8/addons/mp3/decode_i386.c 280737 
>   /branches/1.8/addons/mp3/decode_ntom.c 280737 
>   /branches/1.8/addons/mp3/huffman.h 280737 
>   /branches/1.8/addons/mp3/interface.c 280737 
>   /branches/1.8/addons/mp3/layer3.c 280737 
>   /branches/1.8/addons/mp3/mpg123.h 280737 
>   /branches/1.8/addons/mp3/mpglib.h 280737 
>   /branches/1.8/addons/mp3/tabinit.c 280737 
>   /branches/1.8/contrib/scripts/get_mp3_source.sh PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/836/diff
> 
> 
> Testing
> -------
> 
> Did a test build before and after downloading the mp3 source into the tree.
> 
> 
> Thanks,
> 
> Russell
> 
>