[asterisk-dev] [Code Review] SRTP support for Asterisk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/191/#review1920
-----------------------------------------------------------


Initial run-through. May find more later.


/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/191/#comment4141>

    This iax_pvt never gets unlocked.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/191/#comment4142>

    I recommend changing the wording here from "reinviting" to "direct media." The reason is that connected line-related reinvites are still perfectly possible, just not direct media reinvites.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/191/#comment4143>

    I think this is impossible since both of the conditions of the logical OR in the if statement require len to be greater than 0.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/191/#comment4144>

    Another impossible to reach block.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/191/#comment4145>

    It seems a bit odd that the various process_* functions have different meanings for their return values.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/191/#comment4146>

    Could you document what these new return values mean?



/trunk/channels/sip/sdp_crypto.c
<https://reviewboard.asterisk.org/r/191/#comment4147>

    This if is unnecessary. You can free NULL pointers with no ill effect.



/trunk/funcs/func_secure.c
<https://reviewboard.asterisk.org/r/191/#comment4148>

    Red splotch


- Mark


On 2010-04-28 15:17:48, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/191/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 15:17:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> SRTP support for Asterisk using Sdescriptions. This has been sitting around for a while, so I figured that it should at least get some review.  Full description of setup at http://lists.digium.com/pipermail/asterisk-dev/2009-January/036029.html
> 
> 
> This addresses bug 5413.
>     https://issues.asterisk.org/view.php?id=5413
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 259665 
>   /trunk/channels/chan_iax2.c 259665 
>   /trunk/channels/chan_sip.c 259665 
>   /trunk/channels/sip/dialplan_functions.c 259665 
>   /trunk/channels/sip/include/sdp_crypto.h PRE-CREATION 
>   /trunk/channels/sip/include/sip.h 259665 
>   /trunk/channels/sip/include/srtp.h PRE-CREATION 
>   /trunk/channels/sip/sdp_crypto.c PRE-CREATION 
>   /trunk/channels/sip/srtp.c PRE-CREATION 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 259665 
>   /trunk/funcs/func_channel.c 259665 
>   /trunk/funcs/func_secure.c PRE-CREATION 
>   /trunk/include/asterisk/autoconfig.h.in 259665 
>   /trunk/include/asterisk/frame.h 259665 
>   /trunk/include/asterisk/global_datastores.h 259665 
>   /trunk/include/asterisk/res_srtp.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 259665 
>   /trunk/main/asterisk.exports.in 259665 
>   /trunk/main/channel.c 259665 
>   /trunk/main/global_datastores.c 259665 
>   /trunk/main/rtp_engine.c 259665 
>   /trunk/makeopts.in 259665 
>   /trunk/res/res_rtp_asterisk.c 259665 
>   /trunk/res/res_srtp.c PRE-CREATION 
>   /trunk/res/res_srtp.exports.in PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/191/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Terry
> 
>