[asterisk-dev] [Code Review] SRTP support for Asterisk

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/191/
-----------------------------------------------------------

(Updated 2010-04-28 15:17:48.565739)


Review request for Asterisk Developers.


Changes
-------

Finally, here is a version of the SRTP branch that is up to date with trunk. I have tested audio, video, and RTCP and it appears to work. I need to update the CHANGES file and also add some documentation and examples. I'll start working on that now, but that is no reason for someone to not start reviewing the code.

The Mantis issue has been open for nearly 5 years and this review request has been on reviewboard for more than a year. Time to get with it. ;-)


Summary
-------

SRTP support for Asterisk using Sdescriptions. This has been sitting around for a while, so I figured that it should at least get some review.  Full description of setup at http://lists.digium.com/pipermail/asterisk-dev/2009-January/036029.html


This addresses bug 5413.
    https://issues.asterisk.org/view.php?id=5413


Diffs (updated)
-----

  /trunk/build_tools/menuselect-deps.in 259665 
  /trunk/channels/chan_iax2.c 259665 
  /trunk/channels/chan_sip.c 259665 
  /trunk/channels/sip/dialplan_functions.c 259665 
  /trunk/channels/sip/include/sdp_crypto.h PRE-CREATION 
  /trunk/channels/sip/include/sip.h 259665 
  /trunk/channels/sip/include/srtp.h PRE-CREATION 
  /trunk/channels/sip/sdp_crypto.c PRE-CREATION 
  /trunk/channels/sip/srtp.c PRE-CREATION 
  /trunk/configure UNKNOWN 
  /trunk/configure.ac 259665 
  /trunk/funcs/func_channel.c 259665 
  /trunk/funcs/func_secure.c PRE-CREATION 
  /trunk/include/asterisk/autoconfig.h.in 259665 
  /trunk/include/asterisk/frame.h 259665 
  /trunk/include/asterisk/global_datastores.h 259665 
  /trunk/include/asterisk/res_srtp.h PRE-CREATION 
  /trunk/include/asterisk/rtp_engine.h 259665 
  /trunk/main/asterisk.exports.in 259665 
  /trunk/main/channel.c 259665 
  /trunk/main/global_datastores.c 259665 
  /trunk/main/rtp_engine.c 259665 
  /trunk/makeopts.in 259665 
  /trunk/res/res_rtp_asterisk.c 259665 
  /trunk/res/res_srtp.c PRE-CREATION 
  /trunk/res/res_srtp.exports.in PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/191/diff


Testing
-------


Thanks,

Terry