[asterisk-dev] [Code Review] CLI command 'manager show settings'

[paul.belanger at polybeacon.com]

> On 2010-04-28 09:54:55, Mark Michelson wrote:
> > /trunk/include/asterisk/manager.h, line 99
> > <https://reviewboard.asterisk.org/r/630/diff/2/?file=9659#file9659line99>
> >
> >     A few comments:
> >     
> >     If you want to move this to a common header file, that's fine. However, it doesn't really seem logical to put it in manager.h. I think cli.h would be a better fit.
> >     
> >     Also, put parentheses around x in the macro definition:
> >     
> >     #define AST_CLI_YESNO(x) (x) ? "Yes" : "No"

Fixed.


> On 2010-04-28 09:54:55, Mark Michelson wrote:
> > /trunk/main/manager.c, lines 743-745
> > <https://reviewboard.asterisk.org/r/630/diff/2/?file=9660#file9660line743>
> >
> >     Why did you add these lines?

Fixed.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/630/#review1908
-----------------------------------------------------------


On 2010-04-28 10:55:22, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/630/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 10:55:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds 'manager show settings' CLI command.  Most of the logic was used from chan_sip.c.
> 
> 
> This addresses bug 16343.
>     https://issues.asterisk.org/view.php?id=16343
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 259663 
>   /trunk/include/asterisk/cli.h 259663 
>   /trunk/include/asterisk/manager.h 259663 
>   /trunk/main/manager.c 259663 
> 
> Diff: https://reviewboard.asterisk.org/r/630/diff
> 
> 
> Testing
> -------
> 
> Local developers and testing boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>