[asterisk-dev] [Code Review] CLI command 'manager show settings'

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/630/#review1908
-----------------------------------------------------------



/trunk/include/asterisk/manager.h
<https://reviewboard.asterisk.org/r/630/#comment4126>

    A few comments:
    
    If you want to move this to a common header file, that's fine. However, it doesn't really seem logical to put it in manager.h. I think cli.h would be a better fit.
    
    Also, put parentheses around x in the macro definition:
    
    #define AST_CLI_YESNO(x) (x) ? "Yes" : "No"



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/630/#comment4127>

    Why did you add these lines?


- Mark


On 2010-04-27 19:42:12, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/630/
> -----------------------------------------------------------
> 
> (Updated 2010-04-27 19:42:12)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds 'manager show settings' CLI command.  Most of the logic was used from chan_sip.c.
> 
> 
> This addresses bug 16343.
>     https://issues.asterisk.org/view.php?id=16343
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 259661 
>   /trunk/include/asterisk/manager.h 259661 
>   /trunk/main/manager.c 259661 
> 
> Diff: https://reviewboard.asterisk.org/r/630/diff
> 
> 
> Testing
> -------
> 
> Local developers and testing boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>