[asterisk-dev] [Code Review] Explicit context set in SIPpeeroverridden by default domain context

Philip A. Prindeville philipp_subx at redfish-solutions.com
Thu Apr 22 14:21:03 CDT 2010


On 04/22/2010 07:59 AM, Nick Lewis wrote:
>>> The idea I had with the current domain context 
>>> was just a replacement of the context in
>>> general, without any inheritance to the peer
>>>       
>> I just wonder how there's any connection between a peer and a domain.
>>     
> Not between peer and domain but indirectly between peer and
> domain-context
>  
> I think the problem in the original code is because the general context
> propagates to the peer context during config parsing where as the
> overwriting by domain-context can only happen subsequently at invite
> parsing. At that point it is forgotten whether the context is peer
> specific or the default one from the general settings. 
>
> Instead of the proposed peer-match flag we may need a default-context
> flag and only overwrite with domain-context when set. This would give
> the behavoiur that you wanted i.e. [general]domain-context overwrites
> [general]context but not [peer]context.
>   

I could live with this behavior.

-Philip


> -- N_L
>   




More information about the asterisk-dev mailing list