[asterisk-dev] [Code Review] Explicit context set in SIPpeeroverridden by default domain context

Nick Lewis Nick.Lewis at atltelecom.com
Thu Apr 22 08:59:11 CDT 2010


>> The idea I had with the current domain context 
>> was just a replacement of the context in
>> general, without any inheritance to the peer
>I just wonder how there's any connection between a peer and a domain.

Not between peer and domain but indirectly between peer and
domain-context
 
I think the problem in the original code is because the general context
propagates to the peer context during config parsing where as the
overwriting by domain-context can only happen subsequently at invite
parsing. At that point it is forgotten whether the context is peer
specific or the default one from the general settings. 

Instead of the proposed peer-match flag we may need a default-context
flag and only overwrite with domain-context when set. This would give
the behavoiur that you wanted i.e. [general]domain-context overwrites
[general]context but not [peer]context.

-- N_L

_____________________________________________________________________
This message has been checked for all known viruses by Star Internet delivered through the MessageLabs Virus Control Centre.
_____________________________________________________________________
Disclaimer of Liability
ATL Telecom Ltd shall not be held liable for any improper or incorrect use of the  information described and/or contained herein and assumes no responsibility for anyones use  of the information. In no event shall ATL Telecom Ltd be liable for any direct, indirect,  incidental, special, exemplary, or consequential damages (including, but not limited to,  procurement or substitute goods or services; loss of use, data, or profits; or business  interruption) however caused and on any theory of liability, whether in contract, strict  liability, or tort (including negligence or otherwise) arising in any way out of the use of  this system, even if advised of the possibility of such damage.

Registered Office: ATL Telecom Ltd, Fountain Lane, St. Mellons Cardiff, CF3 0FB
Registered in Wales Number 4335781

All goods and services supplied by ATL Telecom Ltd are supplied subject to ATL Telecom Ltd standard terms and conditions, available upon request.



More information about the asterisk-dev mailing list