[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Julian Lyndon-Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/
-----------------------------------------------------------

(Updated 2010-04-21 04:44:14.587079)


Review request for Asterisk Developers.


Changes
-------

updated comments in audiohook.h, ready to ship :)


Summary
-------

For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....

I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.

MixMonitor now has a new manager command

manager show command MixMonitorMute
Action: MixMonitorMute
[ActionID:] <value>
Channel: <value>
[Direction:] <value>
[State:] <value>

[Synopsis]
Mute / unMute a Mixmonitor recording.

[Description]
This action may be used to mute a MixMonitor recording.

[Arguments]
ActionID
    ActionID for this transaction. Will be returned.
Channel
    Used to specify the channel to mute.
Direction
    Which part of the recording to mute:  read, write or both (from
    channel, to channel or both channels).
State
    Turn mute on or off : 1 to turn on, 0 to turn off.


This addresses bug 16740.
    https://issues.asterisk.org/view.php?id=16740


Diffs (updated)
-----

  trunk/apps/app_mixmonitor.c 258189 
  trunk/include/asterisk/audiohook.h 258189 
  trunk/include/asterisk/frame.h 258189 
  trunk/main/audiohook.c 258189 
  trunk/main/frame.c 258189 
  trunk/res/res_mutestream.c 258189 

Diff: https://reviewboard.asterisk.org/r/487/diff


Testing
-------

Tested on 1.4 : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
Tested on trunk : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time


Thanks,

Julian