[asterisk-dev] [Code Review] LibPRI changes for Generic AOC

[Kevin Fleming]

> On 2010-04-14 16:04:16, rmudgett wrote:
> > /team/rmudgett/aoc_event/pri_aoc.c, lines 1462-1463
> > <https://reviewboard.asterisk.org/r/619/diff/1/?file=9262#file9262line1462>
> >
> >     Just eliminate errorcode so static checkers can verify that the switch cases are members of the enum.
> 
> David Vossel wrote:
>     If I do this i have to include every member of the enum even though i only care about a select few.

Umm... no, you can use 'default' to handle all the enumerators you don't care about. It really is better for the compiler to be able to ensure that the switch cases are of the proper types when possible.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/619/#review1834
-----------------------------------------------------------


On 2010-04-15 12:31:23, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/619/
> -----------------------------------------------------------
> 
> (Updated 2010-04-15 12:31:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review compliments the Asterisk changes in review https://reviewboard.asterisk.org/r/552/.  These are the LibPRI changes required to send ETSI AOC messages generated by Asterisk.
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/aoc_event/libpri.h 1592 
>   /team/rmudgett/aoc_event/pri.c 1592 
>   /team/rmudgett/aoc_event/pri_aoc.c 1592 
>   /team/rmudgett/aoc_event/pri_facility.h 1592 
>   /team/rmudgett/aoc_event/pri_facility.c 1592 
>   /team/rmudgett/aoc_event/pri_internal.h 1592 
>   /team/rmudgett/aoc_event/q931.c 1592 
> 
> Diff: https://reviewboard.asterisk.org/r/619/diff
> 
> 
> Testing
> -------
> 
> These routines have been tested back to back with Asterisk, but I am going to need some community help to test interoperability.
> 
> To test this code, check out both my Asterisk and Libpri changes for AOC
> 
> Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
> LibPRI Changes: svn/libpri/team/dvossel/aoc_send 
> 
> 
> Thanks,
> 
> David
> 
>