[asterisk-dev] [Code Review] LibPRI changes for Generic AOC

[David Vossel]

> On 2010-04-14 16:04:16, rmudgett wrote:
> > /team/rmudgett/aoc_event/pri_aoc.c, line 1457
> > <https://reviewboard.asterisk.org/r/619/diff/1/?file=9262#file9262line1457>
> >
> >     You need to memset() the aoc_request_response structure to zero.  Otherwise the valid_aoc_s flag is uninitialized for most cases.

so, q931_alloc_subcommand() does not give back initialized memory?!


> On 2010-04-14 16:04:16, rmudgett wrote:
> > /team/rmudgett/aoc_event/pri_aoc.c, lines 1462-1463
> > <https://reviewboard.asterisk.org/r/619/diff/1/?file=9262#file9262line1462>
> >
> >     Just eliminate errorcode so static checkers can verify that the switch cases are members of the enum.

If I do this i have to include every member of the enum even though i only care about a select few.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/619/#review1834
-----------------------------------------------------------


On 2010-04-13 17:53:56, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/619/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 17:53:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review compliments the Asterisk changes in review https://reviewboard.asterisk.org/r/552/.  These are the LibPRI changes required to send ETSI AOC messages generated by Asterisk.
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/aoc_event/libpri.h 1592 
>   /team/rmudgett/aoc_event/pri_aoc.c 1592 
>   /team/rmudgett/aoc_event/pri_facility.h 1592 
>   /team/rmudgett/aoc_event/pri_facility.c 1592 
>   /team/rmudgett/aoc_event/pri_internal.h 1592 
>   /team/rmudgett/aoc_event/q931.c 1592 
> 
> Diff: https://reviewboard.asterisk.org/r/619/diff
> 
> 
> Testing
> -------
> 
> These routines have been tested back to back with Asterisk, but I am going to need some community help to test interoperability.
> 
> To test this code, check out both my Asterisk and Libpri changes for AOC
> 
> Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
> LibPRI Changes: svn/libpri/team/dvossel/aoc_send 
> 
> 
> Thanks,
> 
> David
> 
>