[asterisk-dev] [Code Review] fixes deadlock in chan_sip caused by use of MASTER_CHANNEL() dialplan function

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/606/#review1809
-----------------------------------------------------------

Ship it!


Looks good to me. Good job!

- Mark


On 2010-04-06 09:18:54, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/606/
> -----------------------------------------------------------
> 
> (Updated 2010-04-06 09:18:54)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> The use of the MASTER_CHANNEL() dialplan function in chan_sip currently causes a deadlock as it invalidates channel container locking order. This patch moves the MASTER_CHANNEL logic to a place that proper locking order can take place.
> 
> 
> This addresses bug 16767.
>     https://issues.asterisk.org/view.php?id=16767
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 256318 
> 
> Diff: https://reviewboard.asterisk.org/r/606/diff
> 
> 
> Testing
> -------
> 
> made sip calls, verified the sip cause was updated.
> 
> 
> Thanks,
> 
> David
> 
>