[asterisk-dev] [Code Review] fixes deadlock in chan_sip caused by use of MASTER_CHANNEL() dialplan function

David Vossel dvossel at digium.com
Tue Apr 6 09:18:54 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/606/
-----------------------------------------------------------

(Updated 2010-04-06 09:18:54.392848)


Review request for Asterisk Developers and Tilghman Lesher.


Summary (updated)
-------

The use of the MASTER_CHANNEL() dialplan function in chan_sip currently causes a deadlock as it invalidates channel container locking order. This patch moves the MASTER_CHANNEL logic to a place that proper locking order can take place.


This addresses bug 16767.
    https://issues.asterisk.org/view.php?id=16767


Diffs
-----

  /trunk/channels/chan_sip.c 256318 

Diff: https://reviewboard.asterisk.org/r/606/diff


Testing (updated)
-------

made sip calls, verified the sip cause was updated.


Thanks,

David




More information about the asterisk-dev mailing list