[asterisk-dev] [Code Review] AST-33: Create a list of channel variables to be posted within AMI call events

[Lenz Emilitri]

This is great and will undoubtedly be very useful. I really like the idea.
 What worries me is that the configuration is centralized, so I can imagine
 users forgetting to set up this and then code that relies on this breaking
- and people opening up support tickets :)

It would be extra nice if you could set this up when you establish an AMI
connection, maybe with a mask, something like:

SIP/2: OWNER, PEER
SIP/3: OWNER, PEER, ABCD
*: PEER

This would basically mean that we want to see PEER for each channel, we want
OWNER as well for channels that start with SIP/2, and ABCD for SIP/3.

I can also imagine hardcoding GetVars  to help in case such variables don't
come automatically, so this just wants to be some input :)
l.


2009/9/17 Tilghman Lesher <tlesher at digium.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/368/
> -----------------------------------------------------------
>
> (Updated 2009-09-16 20:09:33.517920)
>
>
> Review request for Asterisk Developers.
>
>
> Changes
> -------
>
> Provide an example of output.
>
>
> Summary (updated)
> -------
>
> The intent of this patch is to post various variables from a related
> channel, when posting certain call-related events to the manager interface.
>
> For example, the following manager.conf entry:
>
> channelvars=SV_OWNER,SV_PEER,DISPLAY_URL
>
> will result in the following manager output for a Newstate event:
>
> Event: Newstate
> Privilege: call,all
> Channel: SIP/200-08b75888
> State: Up
> CallerID: 200
> CallerIDName: Snom Phone
> Uniqueid: 1209084781.0
> Channel1Var-SV_OWNER: a1101
> Channel1Var-SV_PEER: a1116
> Channel1Var-DISPLAY_URL:
>
> For Link events, you'll also see Channel2Var-type entries for the
> corresponding bridged channel.
>
>
> Diffs
> -----
>
>  /trunk/apps/app_chanspy.c 219006
>  /trunk/apps/app_dial.c 219006
>  /trunk/apps/app_fax.c 219006
>  /trunk/apps/app_meetme.c 219006
>  /trunk/apps/app_minivm.c 219006
>  /trunk/apps/app_queue.c 219006
>  /trunk/apps/app_voicemail.c 219006
>  /trunk/channels/chan_iax2.c 219006
>  /trunk/channels/chan_sip.c 219006
>  /trunk/configs/manager.conf.sample 219006
>  /trunk/include/asterisk/manager.h 219006
>  /trunk/main/cdr.c 219006
>  /trunk/main/channel.c 219006
>  /trunk/main/features.c 219006
>  /trunk/main/manager.c 219006
>  /trunk/res/res_monitor.c 219006
>  /trunk/res/res_musiconhold.c 219006
>
> Diff: https://reviewboard.asterisk.org/r/368/diff
>
>
> Testing
> -------
>
> It compiles!  Ship it!
>
>
> Thanks,
>
> Tilghman
>
>
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
>
> AstriCon 2009 - October 13 - 15 Phoenix, Arizona
> Register Now: http://www.astricon.net
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev
>



-- 
Loway - home of QueueMetrics - http://queuemetrics.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20090917/f9b19d07/attachment.htm